Skip to content

Commit

Permalink
Add 'allowCreate: false' to sp config and downgraded smalify
Browse files Browse the repository at this point in the history
* samlify sets an empty string as default for AllowCreate in authn request which
  leads to errors in some IdPs.
* samlify in 2.8.11 does not recognize the AllowCreate attribute so it is
  downgraded to 2.8.10 (tngan/samlify#538)
  • Loading branch information
rrenkert committed Apr 12, 2024
1 parent 3a8530d commit 83e775e
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 21 deletions.
26 changes: 7 additions & 19 deletions auth/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion auth/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
"jsonwebtoken": "^9.0.2",
"response-time": "^2.3.2",
"rest-app": "^1.0.0-alpha.9",
"samlify": "^2.8.11",
"samlify": "2.8.10",
"tslib": "^2.6.2"
}
}
3 changes: 2 additions & 1 deletion auth/src/express/controllers/saml-controller.ts
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,8 @@ export class SamlController {
});
return samlify.ServiceProvider({
metadata: (await this.getSamlSettings()).saml_metadata_sp,
privateKey: (await this.getSamlSettings()).saml_private_key
privateKey: (await this.getSamlSettings()).saml_private_key,
allowCreate: false
});
}

Expand Down

0 comments on commit 83e775e

Please sign in to comment.