Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated ActivationThrottler to compute limit and compare against totalInflightActivations in cluster #1

Open
wants to merge 1 commit into
base: update-error-responses
Choose a base branch
from
Open

Updated ActivationThrottler to compute limit and compare against totalInflightActivations in cluster #1

wants to merge 1 commit into from

Conversation

rraavi
Copy link
Owner

@rraavi rraavi commented Oct 2, 2020 •
edited
Loading

Addressing comment from apache#4972 (comment)

@rraavi
Copy link
Owner Author

rraavi commented Oct 2, 2020 •
edited
Loading

actionInvokesConcurrent limit set by a user gets diluted here 👇

openwhisk/core/controller/src/main/scala/org/apache/openwhisk/core/entitlement/Entitlement.scala

Line 131 in e0e5946

(limit / loadBalancer.clusterSize).max(1)

.
Therefore the change I proposed computes limit again and then checks against total inflight activations for the cluster

@rraavi rraavi changed the title Updated to ActivationThrottler to compute limit and compare against totalInflightActivations in cluster Updated ActivationThrottler to compute limit and compare against totalInflightActivations in cluster Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rraavi