Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix manual publish option to skip publish to PyPA #135

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

ketozhang
Copy link
Contributor

Broken, because the if condition I had didn't work as intended. Now you can toggle on to disable and off to enable publish to PyPA.

See example, the publish stage should be skipped (not failure)
https://github.com/ketozhang/MulensModel/actions/runs/8871760998

@rpoleski rpoleski merged commit 3e96b60 into rpoleski:master Apr 29, 2024
1 check passed
@rpoleski
Copy link
Owner

Thanks.
Do you know how to setup codecov or similar action? It was working for years and recently started stating that there is 0% coverage of all files and producing some error messages. After a few tries correcting it, I gave up. If possible, I'd like to have something that tells what is the coverage of modified code for a pull request.

@ketozhang
Copy link
Contributor Author

Yeah we can take a look---set up coverage to show up on PR. Related to #65.

@rpoleski
Copy link
Owner

I've already forgotten about #65, the list might be outdated. My current approach is to have 100% (except plotting and some unexpected values) coverage of code that is added.
I removed codecov in 8af13bc, you may find failed codecov runs based on the date, if that is helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants