-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed deprecated stuff in Version3_1 branch #126
Conversation
Looks good to me. |
What kind of checks do we have that all of the deprecated code is removed? For example, in Event, we are removing _apply_fit_blending(). Have we verified that there is no longer any code that calls this? I imagine that if we missed removing some instance of fit_blending, then the error the user would see is that _apply_fit_blending() does not exist, which is not very helpful. Otherwise, fine. |
We have tests that pass. They also call ~75% of the code and at some point I've verified that the code not tested is almost exclusively plotting and test of stupid input values. This brings testing of plotting - @rapoliveira can you please run all the examples and check that none of them produces errors? Then we can merge. |
My last commit updates the few calls to deprecated functions in the examples. Examples 01, 08, 13, 15, 16, 19, 20, 21 and 23 produce the same error below, which is not related with my changes.
|
Also note that changing to
produces a different error:
This error repeats for many examples, so there is probably a single error that causes them. @jenniferyee can you solve it? |
I finished removing all the deprecated functions, arguments and values in Version3_1 branch. Adaptations in the code and in unit tests were necessary in a few cases.
The unit tests keep failing in the same 24 tests as before, mainly in VBBL and PSBL functions (issue #116).