Skip to content

Commit

Permalink
correcting description of Skowron+11 conventions
Browse files Browse the repository at this point in the history
  • Loading branch information
rpoleski committed May 4, 2019
1 parent 5b19d90 commit e98a982
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
7 changes: 4 additions & 3 deletions source/MulensModel/modelparameters.py
Original file line number Diff line number Diff line change
Expand Up @@ -675,9 +675,10 @@ def alpha(self):
The angle of the source trajectory relative to the binary lens
axis (or primary-secondary axis). Measured counterclockwise,
i.e., according to convention advocated by `Skowron et
al. 2011 (ApJ, 738, 87)
<http://adsabs.harvard.edu/abs/2011ApJ...738...87S>`_. May be
i.e., according to convention advocated by
`Skowron et al. 2011 (ApJ, 738, 87)
<http://adsabs.harvard.edu/abs/2011ApJ...738...87S>`_,
but shifted by 180 deg. May be
set as a *float* --> assumes "deg" is the default unit.
Regardless of input value, returns value in degrees.
"""
Expand Down
5 changes: 3 additions & 2 deletions source/MulensModel/trajectory.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ class Trajectory(object):
This class follows the conventions defined in Appendix A of
`Skowron et al. (2011)
<http://adsabs.harvard.edu/abs/2011ApJ...738...87S>`_.
<http://adsabs.harvard.edu/abs/2011ApJ...738...87S>`_
except the definition of *alpha*, which is shifted by 180 deg.
Arguments :
times: [*float*, *list*, *np.ndarray*], required
Expand Down Expand Up @@ -164,7 +165,7 @@ def get_xy(self):
vector_y = vector_tau * sin_alpha + vector_u * cos_alpha
# The above equations use alpha in counterclockwise
# convention, i.e., the same as proposed by Skowron et
# al. (2011)
# al. (2011), but shifted by 180 deg.
else:
raise NotImplementedError(
"trajectory for more than 2 lenses not handled yet")
Expand Down

0 comments on commit e98a982

Please sign in to comment.