Reset recursion depth for error message #3209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a test (which should be pretty easy for this one). |
|
I also wonder why the change from the |
$ rpm --define 'aaa %[%aaa]' --eval '%aaa' let to a core dump due to a stack overflow. This was cause by the generation of the error message failing due to being too deep in the recursion of the macro expansion - creating more error messages. Resetting the depth counter allows rendering the error message. As we are failing and breaking off the parse run this is fine to do. Thanks to Miro Hrončok for reporting Resolves: rpm-software-management#3197
|
Done! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$ rpm --define 'aaa %[%aaa]' --eval '%aaa'
let to a core dump due to a stack overflow. This was cause by the generation of the error message failing due to being too deep in the recursion of the macro expansion - creating more error messages.
Resetting the depth counter allows rendering the error message. As we are failing and breaking off the parse run this is fine to do.
Thanks to Miro Hrončok for reporting
Resolves: #3197