Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sinfoCmp to order signatures correctly #3194

Closed
wants to merge 2 commits into from

Commits on Jul 18, 2024

  1. Fix sinfoCmp to order signatures correctly

    This requires adjusting a number of test that reflect the ordering. The
    changes in tests/rpmsigdig.at look straight forward and correct - just
    changing the order in which the signatures and checksums are presented.
    
    The changes in tests/rpmi.at seem to drop the relevant information. This
    might be accidental as the code just returns the first issue found. But
    "no signature" seems kinda weird result when before it complaint about a
    specific signature. The next patch tries to fix that.
    
    Resolves: rpm-software-management#3185
    ffesti committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    23a0bea View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Report most severe signature issue

    Don't rely on the fist issue found being the most meaningful. Always
    return 1 to loop through all signatures / hashes. Use the first error of
    the highest severity.
    
    Using the severity in vd->type[] is a bit of a hack but OK as it is only
    checked for == RPMRC_OK (aka 0) in verifyPackageFiles.
    
    Related: rpm-software-management#3185
    ffesti committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    a242ec7 View commit details
    Browse the repository at this point in the history