Add warning for %autopatch not applying anything #3189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible that the range given to %autopatch is not matching any actual patches. Issue an warning to give the packager a chance to realize that there is something fishy. Not turnng this into an error to not break existing builds. Resolves: rpm-software-management#3093
dmnks
reviewed
Jul 9, 2024
| @@ -468,11 +468,13 @@ RPMDB_INIT | |||
| RPMTEST_CHECK([ | |||
|
|
|||
| run rpmbuild \ | |||
| -ba ${RPMDATA}/SPECS/hello-autopatch.spec | |||
| -ba ${RPMDATA}/SPECS/hello-autopatch.spec 2> >(grep warning >&2) | grep warning | |||
|
This causes a regression where %autosetup emits warnings when there are no patches (which for %autosetup is perfectly normal): #3230 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible that the range given to %autopatch is not matching any actual patches. Issue an warning to give the packager a chance to realize that there is something fishy. Not turnng this into an error to not break existing builds.
Resolves: #3093