Convert the last rpmhash user to STL and remove rpmhash #3184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is unlike all the other typedefs in rpm and only makes things harder to follow. Luckily this is an internal-only thing.
fpCacheGetByFp() has been returning the array from rpmhash GetEntry() as-is, which is a format that STL does not provide. Copy the data into a vector instead to put a little padding between the user and the container. This is slower of course but can't be helped, we can optimize the mess once all the old implementation has been untangled.
pmatilai
changed the title
|
Hashes to ashes 🪦 |
This is a bit trickier than the average hash because it uses pointers to structs as keys, but we need to hash and compare the actual structs and not the pointers. This is was also the last user of rpmhash in the codebase.
It may have been clunky to declare and non-obvious for new-comers but it served us well for many years. Farewell, and thanks for all the fish.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.