Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give better error message for dangerous symlinks #3175

Closed
wants to merge 1 commit into from
Closed

Give better error message for dangerous symlinks #3175

wants to merge 1 commit into from

Commits on Aug 14, 2024

  1. Improve error reporting in the fsm 

    RPM refuses to follow non root owned symlinks pointing to files owned by
another user for security reasons. This case was lumped in with other
issues resulting in us setting errno to ENOTDIR. This led to confusing
as the symlink often indeed points at a directory.

Change fsmOpenat to report back an error code and use rpmfilesErrorCodes
from rpmarchive.h - which are already used in the surrounding code.

Give meaningful error message when encountering unsave symlinks.

Retire the abuse of errno for our own reporting.

Resolves: rpm-software-management#3100
    @ffesti
    ffesti committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    4b19596 View commit details
    Browse the repository at this point in the history