Skip to content

Commit

Permalink
Sort output for test case to avoid race condition
Browse files Browse the repository at this point in the history
Not 100% sure where the race condition actually emerges from as both
messages should come from the same process and only after the urlhelper
has finished. But if this is seen in the wild we better fix it...

Related: #3106
  • Loading branch information
ffesti committed Jul 5, 2024
1 parent 515d252 commit ae40651
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tests/rpmgeneral.at
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,7 @@ AT_KEYWORDS([urlhelper])
RPMDB_INIT
RPMTEST_CHECK([
# runroot rpm --define "_urlhelper /not/there" --root /srv/test -qp https://example.com/foo-0.1-1.noarch.rpm
runroot rpm --define "_urlhelper /not/there" -qp https://www.example.com/foo-1.0-1.x86_64.rpm
runroot rpm --define "_urlhelper /not/there" -qp https://www.example.com/foo-1.0-1.x86_64.rpm 2> >( sort >&2)
],
[1],
[],
Expand All @@ -402,7 +402,7 @@ AT_SETUP([urlhelper fails])
AT_KEYWORDS([urlhelper])
RPMDB_INIT
RPMTEST_CHECK([
runroot rpm --define "_urlhelper /bin/false" --root /srv/test -qp https://example.com/foo-0.1-1.noarch.rpm 2> >(sed 's| /.*rpm-tmp.* https| rpm-tmp https|' >&2)
runroot rpm --define "_urlhelper /bin/false" --root /srv/test -qp https://example.com/foo-0.1-1.noarch.rpm 2> >(sed 's| /.*rpm-tmp.* https| rpm-tmp https|' | sort >&2)
],
[1],
[],
Expand Down

0 comments on commit ae40651

Please sign in to comment.