Skip to content

Conversation

@xsuchy
Copy link
Member

@xsuchy xsuchy commented Aug 27, 2025

I want to try the Gemini review in this repo. I've got good feedback on it from the Packit team.
If no one objects, I will enable
https://github.com/marketplace/gemini-code-assist

I treat it as an experiment. If that makes more noise than help, we can disable it later.

@praiskup
Copy link
Member

-1 for giving it write access to anything. I have nothing against read-only access.

@praiskup
Copy link
Member

Do we have it enabled anywhere else to better understand the benefits?

@xsuchy
Copy link
Member Author

xsuchy commented Aug 28, 2025

Packit uses it. You can see e.g., this PR packit/ai-workflows#103 (see outdated comments)

@xsuchy
Copy link
Member Author

xsuchy commented Aug 28, 2025

Where do you see that it has write access. AFAIK it should only put comments in PR.

@praiskup
Copy link
Member

I haven't checked, I'm just guessing. If it gets read only access, and rights for opening PRs and comments, it seems safe (OTOH, not sure if this isn't implicit). It would be nice to review the granted permissions, otherwise looks OK to me.
Would be nice to inform random contributors that those comments are not a big deal.

@praiskup
Copy link
Member

We've checked it has only read-only access - but we don't have access to rpm-software-management org admins. https://github.com/rpm-software-management/org-admin/issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants