Merge pull request #54 from rpearce/upgrades-and-simplify-ref-logic

Upgrades and simplify ref logic

.all-contributorsrc

@@ -150,6 +150,26 @@
       "contributions": [
         "bug"
       ]
+    },
+    {
+      "login": "simonsmith",
+      "name": "Simon Smith",
+      "avatar_url": "https://avatars0.githubusercontent.com/u/360703?v=4",
+      "profile": "http://simonsmith.io/",
+      "contributions": [
+        "bug",
+        "ideas"
+      ]
+    },
+    {
+      "login": "jordie23",
+      "name": "jordie23",
+      "avatar_url": "https://avatars0.githubusercontent.com/u/712360?v=4",
+      "profile": "https://github.com/jordie23",
+      "contributions": [
+        "bug",
+        "ideas"
+      ]
     }
   ],
   "commitConvention": "none"

.eslintrc.js

@@ -67,6 +67,8 @@ module.exports = {
     semi: ['error', 'never'],
     'space-in-parens': ['error', 'never'],
     'space-infix-ops': ['error'],
+    'no-use-before-define': 'off',
+    '@typescript-eslint/no-use-before-define': ['error'],
   },
   settings: {
     react: {

.github/workflows/ci.yml

@@ -12,8 +12,8 @@ jobs:
     - name: Use Node.js
       uses: actions/setup-node@v1
       with:
-        node-version: '14.x'
-    - run: npm install
+        node-version: '15.x'
+    - run: npm install --legacy-peer-deps
     - run: npm run ci
       env:
         CI: true

CHANGELOG.md

@@ -4,64 +4,84 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## [2.2.4] - 2020-12-03
+
+### Changed
+
+* simplified `ref` logic on `textarea` element
+* patch upgrade to `ts-lib`
+
 ## [2.2.2] - 2020-08-28
 
 ### Fixed
+
 * textareas with `maxHeight` not having a scrollbar (#43)
 
 ## [2.2.2] - 2020-08-28
 
 ### Changed
+
 * README update
 
 ## [2.2.1] - 2020-08-28
 
 ### Changed
+
 * now building output using tsc instead of rollup
 
 ### Fixed
+
 * now exporting the textarea interface (should resolve #47)
 
 ## [2.2.0] - 2020-03-14
 
 ### Added
+
 * typescript support
 
 ### Changed
+
 * license from ISC to BSD-3
 
 ### Fixed
+
 * issue where `line-height` is `normal` and calculation breaks by falling back
   to `fontSize * 1.2`
 * upgrades to fix vulnerabilities
 
 ## [2.1.2] - 2020-02-04
 
 ### Added
+
 * Commonjs `react-expanding-textarea.min.js` build
 * UMD `react-expanding-textarea.min.js` build
 
 ### Fixed
+
 * auto-adjusting issue in firefox (#33)
 
 ### Changed
+
 * changed `browser` field value in package.json to point to
   `dist/umd/react-expanding-textarea.min.js` suffix
 
 ## [2.1.1] - 2020-01-19
 
 ### Fixed
+
 * README
 
 ## [2.1.0] - 2020-01-19
 
 ### Added
+
 * support for forwarding a ref (#36)
 * added `babel-plugin-transform-react-remove-prop-types`
 
 ## [2.0.4] - 2020-01-05
 
 ### Changed
+
 * bumped devDependencies
 * added UMD build
 * changed build location for commonjs and esmodules to `dist/esm/` and
@@ -70,43 +90,52 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 ## [2.0.3] - 2019-10-14
 
 ### Fixed
+
 * Fixed textarea growing before it needed to (#31)
 
 ## [2.0.2] - 2019-09-11
 
 ### Fixed
+
 * `prop-types` was being used but not included as a dependency
 
 ## [2.0.1] - 2019-09-10
 
 ### Changed
+
 * fixed security issues for `sshpk`, `cached-path-relative` and `mixin-deep`
 
 ## [2.0.0] - 2019-09-07
 
 ### Added
+
 * dependency on `prop-types`
 
 ### Changed
+
 * build folder is now `dist/`
 * now building with `rollup`
 * now providing CJS & ESM dist files (`main` and `module` in `package.json`)
 
 ## [1.0.0] - 2019-02-24
 
 ### Added
+
 * responds to both `onChange` and `onInput` callbacks now
 
 ### Changed
+
 * complete rewrite using React hooks. Minimum react peer dependency is now
   `>= 16.8`.
 
 ### Fixed
+
 * includes a fix for #18
 
 ## [0.2.0] - 2018-08-08
 
 ### Added / Fixed
+
 * addressed #14 where the `rows` attribute was being disregarded. Now, it
   provides a means to provide a minimum/default number of `rows`. This is a
   minorversion bump because it will cause the component to behave differently
@@ -115,9 +144,11 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 ## [0.1.10] - 2018-04-29
 
 ### Fixed
+
 * fixed #10 where a change in the value prop was not recalculating the size
 
 ## [0.1.9] - 2017-10-05
 
 ### Fixed
+
 * support for react v16

README.md

@@ -95,11 +95,14 @@ Thanks goes to these wonderful people ([emoji key](https://github.com/kentcdodds
   </tr>
   <tr>
     <td align="center"><a href="https://github.com/chrisdrackett"><img src="https://avatars3.githubusercontent.com/u/4378?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Chris Drackett</b></sub></a><br /><a href="https://github.com/rpearce/react-expanding-textarea/issues?q=author%3Achrisdrackett" title="Bug reports">🐛</a></td>
+    <td align="center"><a href="http://simonsmith.io/"><img src="https://avatars0.githubusercontent.com/u/360703?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Simon Smith</b></sub></a><br /><a href="https://github.com/rpearce/react-expanding-textarea/issues?q=author%3Asimonsmith" title="Bug reports">🐛</a> <a href="#ideas-simonsmith" title="Ideas, Planning, & Feedback">🤔</a></td>
+    <td align="center"><a href="https://github.com/jordie23"><img src="https://avatars0.githubusercontent.com/u/712360?v=4?s=100" width="100px;" alt=""/><br /><sub><b>jordie23</b></sub></a><br /><a href="https://github.com/rpearce/react-expanding-textarea/issues?q=author%3Ajordie23" title="Bug reports">🐛</a> <a href="#ideas-jordie23" title="Ideas, Planning, & Feedback">🤔</a></td>
   </tr>
 </table>
 
 <!-- markdownlint-restore -->
 <!-- prettier-ignore-end -->
+
 <!-- ALL-CONTRIBUTORS-LIST:END -->
 
 This project follows the [all-contributors](https://github.com/kentcdodds/all-contributors) specification. Contributions of any kind welcome!

__tests__/index.tsx

@@ -6,7 +6,7 @@ import '@testing-library/jest-dom/extend-expect'
 import ExpandingTextarea, { getHeight, resize } from '../source'
 
 test('renders with a minimum number of rows', () => {
-  const wrapStyles: React.CSSProperties = {
+  const wrapStyles: CSSProperties = {
     boxSizing: 'border-box',
     maxWidth: '500px',
   }