Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a nice wrapper for get_sys_info #877

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

nahla-nee
Copy link

Implements a nice safe wrapper for get_sys_info as described in #839 .

Copy link
Member

@thejpster thejpster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR. In general it looks great!

I would like to see an example of using this API though.

rp235x-hal/src/rom_data.rs Outdated Show resolved Hide resolved
rp235x-hal/src/rom_data.rs Outdated Show resolved Hide resolved
@nahla-nee
Copy link
Author

Sure! And I'll go ahead make the suggestions changes too. I'll probably do that by tonight (us time). Do you want the example to be added to the existing rom function example? And if so do you want it to replace the existing one?

@thejpster
Copy link
Member

I'm ok with it going into the existing example binary. I'm not sure if we need to leave an example of the old API or if we expect people to only use the new one.

@nahla-nee
Copy link
Author

I also went ahead and added some more documentation. It probably could use more work cause I was in a bit of a rush but it should make things easier to read. I also elaborated on the existing examples since we don't have settle for printing the hex representation of the bytes get_sys_info gives back now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants