Add support for Adafruit CANBus Feather RP2040 #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThadHouse
force-pushed
the
adafruit-canbus-feather-rp2040
branch
3 times, most recently
from
d8c1fcd
to
7a8f7b8
Compare
Adds support for https://www.adafruit.com/product/5724 Copied mostly from the adafruit-feather-rp2040
ThadHouse
force-pushed
the
adafruit-canbus-feather-rp2040
branch
from
7a8f7b8
to
3f4b770
Compare
ithinuel
requested changes
Oct 15, 2023
There was a problem hiding this comment.
Thank you for your contribution, this is greatly appreciated!
Similarly to #45 I think it'd be better having board relevant examples rather than generic that already exist for several of other boards in this repository.
This board has a special purpose revolving around CAN, why not building one that sends/receives some frame on the CAN bus and update the neopixel's state accordingly?
|
Can an example be done in a later PR? From what I've dug into, there's no great MCP2515 CAN Library for Rust, all the ones that exist are pretty iffy. Doesn't make sense to leave these PR's in PR Limbo on examples, when the pin layouts are still worth it to have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for https://www.adafruit.com/product/5724
Copied mostly from the adafruit-feather-rp2040