Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove erase_all function #22

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Remove erase_all function #22

merged 2 commits into from
Feb 20, 2024

Conversation

9names
Copy link
Member

@9names 9names commented Feb 18, 2024

Remove unimplemented erase_all function.
erase_all is a default features of flash-algorithm so we need to add default-features = false in order to skip defining it.
Also renamed the rust-toolchain file to rust-toolchain.toml, since the version without file extension is the old style: "If both files are present in a directory, the latter is used for backwards compatibility"
Resolves #15

@thejpster
Copy link
Member

Has this been tested with probe-rs? Can you paste a screenshot?

@9names
Copy link
Member Author

9names commented Feb 20, 2024

image
Algo was copy-pasted from build.sh into RP2040.yaml, can't use target-gen yet.
image

@thejpster thejpster merged commit 35b9d6f into rp-rs:main Feb 20, 2024
1 check passed
@thejpster
Copy link
Member

target-gen not working might be due to #14 (comment)

@9names
Copy link
Member Author

9names commented Feb 20, 2024

It definitely is. I've tested it with the extra linker keep directives and it works.
The firmware size does grow substantially though, so we should keep it optional like in that PR.
I'm thinking of trying to fix that issue on the target-gen side as well (you don't need that info if updating an existing algo yaml, because it's already in the yaml)

@9names 9names deleted the remove_erase_all branch August 22, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The erase_chip function shouldn't be defined if it always fails
2 participants