Use flash-algorithm crate #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested working with probe-rs CLI. Slightly larger binary, but I can live with that for not having to use nightly rust.
Belt-and-braces in case we ever get a different RP2040 ROM with missing functions. Also use constants for the ROM addresses.
I wasn't sure what the error code should be for ROM Func load failure.
thejpster
force-pushed
the
use-flash-algorithm
branch
from
10ab451
to
e7225ac
Compare
9names
approved these changes
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flash-algorithm crate also implements some description information.
Replaces #14. Builds on #18.