Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROU110] - Add a new rule for disallowing .save() without update fields or comments justifying it #18

Merged
merged 8 commits into from
Mar 8, 2024
Merged

[ROU110] - Add a new rule for disallowing .save() without update fields or comments justifying it #18

merged 8 commits into from
Mar 8, 2024

Conversation

tomharel
Copy link
Contributor

This PR adds a new lint rule ROU110 for disallowing .save() without update fields or comments justifying it.

@tomharel tomharel marked this pull request as ready for review January 26, 2024 20:49
hurgleburgler
hurgleburgler reviewed Mar 8, 2024
View reviewed changes
flake8_routable.py Outdated Show resolved Hide resolved
henriquebastos
henriquebastos approved these changes Mar 8, 2024
View reviewed changes
Copy link

@henriquebastos henriquebastos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. LGTM.

@justmobilize justmobilize merged commit 521b6be into main Mar 8, 2024
1 check passed
@justmobilize justmobilize deleted the rou110-disallow-save-without-update-fields branch March 8, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hurgleburgler hurgleburgler hurgleburgler approved these changes

@henriquebastos henriquebastos henriquebastos approved these changes

@justmobilize justmobilize Awaiting requested review from justmobilize

@rynmlng rynmlng Awaiting requested review from rynmlng

@possiblybob possiblybob Awaiting requested review from possiblybob

@jakec-routable jakec-routable Awaiting requested review from jakec-routable

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomharel @henriquebastos @justmobilize @hurgleburgler