Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typos (?) #94

Merged
merged 1 commit into from
Oct 21, 2024
Merged

typos (?) #94

merged 1 commit into from
Oct 21, 2024

Conversation

da5nsy
Copy link
Contributor

@da5nsy da5nsy commented Oct 18, 2024

No description provided.

@rossjrw
Copy link
Owner

rossjrw commented Oct 18, 2024

What about this do you feel is a typo?

@rossjrw rossjrw closed this Oct 18, 2024
@da5nsy
Copy link
Contributor Author

da5nsy commented Oct 18, 2024

Sorry, I was rushing - I should've provided some context.

The lines that I suggested changes to come from the example "accompanying main deployment workflow" so the workflow isn't deploying previews - it's the main deploy (if I'm understanding correctly). I found this slightly confusing when I was trying to understand the documentation, and my assumption was that it was an inadvertent copy paste of the workflow above it on the page.

As a side note: thank you for providing those examples, they really helped me to understand how to use the action and to get up and running with it quickly.

@rossjrw
Copy link
Owner

rossjrw commented Oct 21, 2024

Agghh - yes, of course! I'm guilty of rushing too, I assumed that the changes were applied to the first example in the README. In this case, yes, these are definitely typos. Apologies for my hastiness and thanks for taking it on the chin!

Thanks for the contribution!

@rossjrw rossjrw reopened this Oct 21, 2024
@rossjrw rossjrw added the documentation Improvements or additions to documentation label Oct 21, 2024
@rossjrw rossjrw merged commit 52ddf53 into rossjrw:main Oct 21, 2024
1 check failed
@da5nsy da5nsy deleted the patch-1 branch October 21, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants