#73 Convert CID to SQL statements #96
Conversation
heubi95
commented
Mar 12, 2015
heubi95
commented
- implemented as_sql_create_inserts function to generate insert statements from a cid and a data file
- coverage improvement
implemented as_sql_create_inserts to create inserts from a cid object and validio.Reader object
| @@ -90,6 +90,14 @@ def test_fails_on_invalid_character(self): | |||
| "character 'x' (code point U+0078, decimal 120) in field 'something' at column 3 must be an allowed" | |||
| " character: 97...99", six.text_type(anticipated_error)) | |||
|
|
|||
| def test_can_raise_not_implemented_error(self): | |||
There was a problem hiding this comment.
No need to test for NotImplementedError, please remove this test case.
|
Concerning the second |
| @@ -281,7 +282,7 @@ def __init__(self, description, default=None): | |||
| # Handle "...". | |||
| raise errors.InterfaceError( | |||
| 'ellipsis (...) must be preceded and/or succeeded by number', location) | |||
| else: | |||
| else: # maybe useless?! | |||
There was a problem hiding this comment.
Replace whole else clause with assert False.
|
What error messages do we get for:
|
| @@ -427,7 +428,7 @@ def _item_contains(self, item, value): | |||
| lower = item[0] | |||
| upper = item[1] | |||
| if lower is None: | |||
| if upper is None: | |||
| if upper is None: # ?? | |||
There was a problem hiding this comment.
Cleaned this up with #97, just merge.
implemented ansi sql dialect
implemented ansi sql dialect
Conflicts: cutplace/sql.py
|
@heubi95: Patrick's changes have been merged so you should be able to continue with this. |
* implemented OracleSqlDialect class * implemented MSSqlDialect class * changed keywords to lowercase * is_keyword function is now case insensitive
Conflicts: cutplace/sql.py tests/test_sql.py
Conflicts: cutplace/sql.py tests/test_sql.py
* implemented DB2SqlDialect * implemented test cases
|
Please resubmit as discussed (to avoid messing with broken branches/forks/work copies/whatnot). |
