Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup range parsers #97

Open
roskakori opened this issue Mar 15, 2015 · 0 comments
Open

Cleanup range parsers #97

roskakori opened this issue Mar 15, 2015 · 0 comments
Labels

Comments

@roskakori
Copy link
Owner

The current parser for range.Range and range.DecimalRange are pretty messy and could use a clean up. Issues to be fixed are:

  • Better code reuse; there's quiet a lot of copy and paste in there which might be collected in a common base class.
  • The following cases should result in an improved error message:
    • 1 2
    • 1 x 2
    • 1 Tab 2
  • Range.items should return a tuple instead of a list so it cannot be modified after Range.__init__()
@roskakori roskakori self-assigned this Mar 15, 2015
roskakori added a commit that referenced this issue Mar 15, 2015
Cleaned up unreachable code.
@roskakori roskakori removed their assignment Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant