Refactor updateQuality method and add more tests#50
Open
alexandrastroiu wants to merge 4 commits intorosedu:mainfrom
Open
Refactor updateQuality method and add more tests#50alexandrastroiu wants to merge 4 commits intorosedu:mainfrom
alexandrastroiu wants to merge 4 commits intorosedu:mainfrom
Conversation
Fix the two tests for the updateQuality function in the gilded-rose.spec.ts file. Signed-off-by: Alexandra Stroiu <alexandra.stroiu@stud.acs.upb.ro>
- Ensure the quality of an item is never negative. - Ensure the quality of Aged Brie or Backstage Passes never exceeds 50. - Verify that the quality increases for Aged Brie and Backstage Passes as the SellIn approaches. - Verify that the quality for Backstage Passes drops to 0 after the concert. - Ensure the quality of Sulfuras is 80 and never alters. - Ensure SellIn value for Sulfuras never alters. - Ensure SellIn value decreases by 1 for all items except Sulfuras. - Add two more test cases to validate that the quality of Backstage Passes increases. - Ensure the quality is not above 50 using a single test. - Add test to verify quality degrading twice as fast once the SellIn date has passed. - Add tests for Conjured items. - Verify SellIn and quality values in Backstage Passes test. Signed-off-by: Alexandra Stroiu <alexandra.stroiu@stud.acs.upb.ro>
Format code in the gilded-rose.spec.ts file. Signed-off-by: Alexandra Stroiu <alexandra.stroiu@stud.acs.upb.ro>
Change the test for the Suflura item in the gilded-rose.spec.ts file: fix the name of the item. Modify the updateQuality method in the gilded-rose.ts file. Also change the test for Conjured items in the gilded-rose.spec.ts file. Signed-off-by: Alexandra Stroiu <alexandra.stroiu@stud.acs.upb.ro>
alexandrastroiu
force-pushed
the
refactor_code
branch
from
aca2225 to
bdac765
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor updateQuality method in the gilded-rose.ts file and add more tests in the gilded-rose.spec.ts file.