Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope to install the "common" XMLs from sros2/test/policies/common? #270

Open
aprotyas opened this issue Jun 25, 2021 · 1 comment
Open

Comments

@aprotyas
Copy link
Member

Feature request

Feature description

Is it possible to rearrange the structure of the repository such that the "common" XML files under sros2/test/policies/common are installed and accessible through importlib/the ament resource index?
I am writing a nodl_to_policy tool, that generates ROS 2 access control policies from their corresponding NoDL description files. In that conversion, each node in the ROS graph receives default permissions for a common set of services/topics/actions, and this common set is described in the XML files under sros2/test/policies/common. In adhering to DRY principles, I would like not to repeat these same "common" resources within the nodl_to_policy tree, but rather access said files through importlib/the ament resource index.

Implementation considerations

Move the entire sros2/test/policies subtree to sros2/data/policies? I'm not sure how that affects the rest of the testing, but I can gladly poke into it.

@mikaelarguedas
Copy link
Member

I believe the intent of #147 was to provide plumbing for this. It seems that it's been stale for a long time though, if you have time / opportunity of picking it up it would be a better way of resolving this issue.

The other "test" policies do not belong in the install folder IMO as they are just examples and should be provided by the packages providing the corresponding nodes and not by sros2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants