Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permission validity should be configurable #186

Open
mikaelarguedas opened this issue Apr 2, 2020 · 6 comments
Open

Permission validity should be configurable #186

mikaelarguedas opened this issue Apr 2, 2020 · 6 comments

Comments

@mikaelarguedas
Copy link
Member

Feature request

Feature description

Generated permissions file should use the same validity period as the certificates.
Currently they use hard coded timeframe that expires in 2023

<not_before>2013-10-26T00:00:00</not_before>

Implementation considerations

Certificates currently use [UTC:UTC+10years]

utcnow = datetime.datetime.utcnow()

The same could be used.

Ideally the user would be able to specify the start date and the dureation. That range would be applied to both the certificates and permissions files

@mikaelarguedas mikaelarguedas mentioned this issue Apr 2, 2020
7 tasks
@kyrofa
Copy link
Member

kyrofa commented Apr 2, 2020

The same could be used.

That sounds like a bug, and could be fixed after feature freeze.

Ideally the user would be able to specify the start date and the duration.

Yeah, that's more of a feature.

@hidmic
Copy link
Contributor

hidmic commented Apr 23, 2020

@kyrofa @mikaelarguedas are you planning to land said feature for Foxy?

@kyrofa
Copy link
Member

kyrofa commented Apr 23, 2020

It's after feature freeze now, so I suspect we'll go the bugfix route on this one.

@dirk-thomas
Copy link
Member

I don't know what this needs to be merged but we haven't frozen yet. It might still be ~ a day out.

@mikaelarguedas
Copy link
Member Author

I won't work on this in the next couple days. I should be able to provide a bugfix to have matching validity dates next week

@mikaelarguedas
Copy link
Member Author

bugfix submitted at #205

@mikaelarguedas mikaelarguedas changed the title [foxy] Permission validity should match certificate validity [foxy] Permission validity should be congurable May 7, 2020
@mikaelarguedas mikaelarguedas changed the title [foxy] Permission validity should be congurable Permission validity should be congurable May 7, 2020
@mikaelarguedas mikaelarguedas changed the title Permission validity should be congurable Permission validity should be configurable May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants