Tick-tock _complex_value -> _nested_data #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: methylDragon <[email protected]>
|
Comment on lines
+1348
to
+1351
| /** | ||
| * \deprecated `dynamic_data_get_complex_value` is deprecated in favor of | ||
| * `dynamic_data_get_nested_data` | ||
| */ |
There was a problem hiding this comment.
Could we just rename the fields in the struct?
I am assuming that the API of this package is the one in dynamic_data.h, and that the struct defined in this header is the interface that the implementations should provide.
There was a problem hiding this comment.
If we rename it, rosidl_dynamic_typesupport_fastrps (and any other dependent packages) will be broken until the other PR is merged. I am fine if we're okay with that, since this is targeting rolling (and we don't have to care about ABI (?)), in which case we should merge the two PRs together.
There was a problem hiding this comment.
We need an opinion from the project lead. @clalancette what do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A method rename (tick-tocked) as requested by: