-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run test_tracetools tests against rmw_zenoh_cpp #140
base: rolling
Are you sure you want to change the base?
Run test_tracetools tests against rmw_zenoh_cpp #140
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a draft, because it requires having the Zenoh router running
CI is gonna be responsible for this, right? unless, rmw_zenoh_cpp cannot run the CI or any tests? I do not really know what the plan here though...
Yeah, we are going to have to figure out how to ensure that the router is running (both for ci.ros2.org and the Rpr jobs) so that the |
In this case, I can easily launch |
321f2e5
to
b546645
Compare
b546645
to
7ff65b4
Compare
Relevant rmw_zenoh issue: ros2/rmw_zenoh#391 |
7eb2ecc
to
6ee04af
Compare
Signed-off-by: Christophe Bedard <[email protected]>
6ee04af
to
e42f923
Compare
Requires ros2/rmw_zenoh#294
This is a draft, because it requires having the Zenoh router running:
Also, this probably should not be merged before
rmw_zenoh_cpp
officially becomes a tier 1rmw
implementation and gets included in the ROS 2 core (andros2.repos
), although thermw_zenoh_cpp
will just be skipped if it's not found.action-ros-ci-repos-supplemental: https://gist.githubusercontent.com/christophebedard/f6d9a7622553946589d6a22d00f41763/raw/7a5b0ee8a55511bf3adaa6cb8dfba10637d69d0c/zenoh.repos