Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for building on Fedora #4795

Open
wants to merge 1 commit into
base: jazzy
Choose a base branch
from

Conversation

tedzards509
Copy link

This introduces a more or less hacky workaround. I am not sure if these system variables are set to the correct values.

I think this should be added anyway, because it helped me build on Fedora.

This introduces a more or less hacky workaround. I am not sure if these system variables are set to the correct values.

I think this should be added anyway, because it helped me build on Fedora.

Signed-off-by: Ted Zards <[email protected]>
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain more about what works and doesn't work without this? Because this doesn't make much sense; ROS 2 isn't dependent on RPM environment variables being set.

@tedzards509
Copy link
Author

This is about qt_gui_cpp not building on Fedora without those system variables being set. It just has to be set for building that package with colcon build --symlink-install on Fedora.

Comment on lines +148 to +150
export RPM_PACKAGE_RELEASE=1.0
export RPM_PACKAGE_VERSION=1.0
export RPM_PACKAGE_NAME=qt_gui_cpp
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am not sure if these environmental variables are statically assigned like this since those are configured for each pacakge description? but this is just a source build tutorial, not creating the rpm package, so that would be okay?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure - I just copied what was done in the issue linked (ros2/ros2#1491) since it worked for me. I was also confused by the name being that package.

Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is obviously the problem with rpm configuration, https://bugzilla.redhat.com/show_bug.cgi?id=2043092 other language such as ruby also meets this problem?

IMO, having this work-around in this tutorial would be okay, so that ROS 2 users with RHEL do not need to search the work-around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants