-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Visualizing ROS 2 data with Foxglove #4620
Conversation
Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: Bahram Banisadr <[email protected]>
Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: Bahram Banisadr <[email protected]>
Signed-off-by: Bahram Banisadr <[email protected]>
@clalancette @audrow could I get a review when you have a chance? |
cc @kscottz |
I hit the CI for you and did a cursory review. I didn't see anything wrong with the update itself. One thing that I think might need discussion is the location in the document tree. We've been moving most of the third-party project documents to this location. I believe the original file may pre-date that recedent. If we're updating this doc we should update the location as well. @clalancette @fujitatomoya do you have any thoughts with regard to this? |
i think this is good idea. @banisadr btw, awesome gundom picture, i love that. |
Yeah, I actually agree that we should move this to the "Related Projects" part of the site, because it is not part of the core. So @banisadr please do that as well. |
@banisadr friendly ping |
Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: Bahram Banisadr <[email protected]>
…e-updates Merging latest from rolling
Thanks @fujitatomoya @clalancette @kscottz! I moved it over to related projects and did a local test build. Nav/ToC seem to be working. Let me know if there's anything else I should update. |
ping @fujitatomoya |
@clalancette can you review this and merge? |
Ping @clalancette @audrow 🙏 |
Looks like this was resolved in conversation. Let me know if this isn't the case.
Looks like everything passes and all requests have been addressed. I'll go ahead and merge this. Thanks for being patient while we were all at ROSCon. |
Thank you! |
The current how-to guide for Foxglove with ROS 2 is outdated and contains multiple factual inaccuracies. Updating to correct.