Pass All Tests in ros2.repos

[YuanYuYuan]

name	list	reason
rosbag2_transport	1 - test_play__rmw_zenoh_cpp (Timeout)	Unknown Timeout
rosbag2_transport	14 - test_burst__rmw_zenoh_cpp (Timeout)	Flaky
test_rmw_implementation	4 - test_publisher__rmw_zenoh_cpp (Failed)	#418
test_rmw_implementation	5 - test_subscription__rmw_zenoh_cpp (Failed)	#418
test_rmw_implementation	9 - test_wait_set__rmw_zenoh_cpp (Failed)	#418
test_rmw_implementation	10 - test_graph_api__rmw_zenoh_cpp (Failed)	#418
test_rmw_implementation	11 - test_unique_identifiers__rmw_zenoh_cpp (Failed)	#418
test_rmw_implementation	12 - test_service__rmw_zenoh_cpp (Failed)	#418
test_rmw_implementation	13 - test_client__rmw_zenoh_cpp (Failed)	#418
test_rmw_implementation	16 - test_event__rmw_zenoh_cpp (Failed)	matched_status.current_count_change
image_transport	8 - image_transport-single_subscriber_publisher (Failed)	ros-perception/image_common#347
message_filters	1 - message_filters-test_simple (Failed)	ros2/message_filters#167
message_filters	2 - message_filters-msg_cache_unittest (Failed)	ros2/message_filters#167
message_filters	3 - message_filters-test_chain (Failed)	ros2/message_filters#167
message_filters	4 - message_filters-test_time_sequencer (Failed)	ros2/message_filters#167
message_filters	5 - message_filters-test_subscriber (Failed)	ros2/message_filters#167
message_filters	7 - message_filters-time_synchronizer_unittest (Failed)	ros2/message_filters#167
message_filters	8 - message_filters-test_exact_time_policy (Failed)	ros2/message_filters#167
message_filters	9 - message_filters-test_approximate_time_policy (Failed)	ros2/message_filters#167
message_filters	10 - message_filters-test_approximate_epsilon_time_policy (Failed)	ros2/message_filters#167
point_cloud_transport	9 - point_cloud_transport-single_subscriber_publisher (Failed)	ros-perception/point_cloud_transport#110
rviz_default_plugins	5 - image_display_test (Failed)	ros2/rviz#1343
rviz_default_plugins	29 - transformer_guard_test (Failed)	ros2/rviz#1343
test_tf2	1 - buffer_core_test (Failed)	ros2/geometry2#762
test_tf2	2 - test_message_filter (Failed)	ros2/geometry2#762
test_tf2	5 - test_buffer_client_tester.launch.py (Failed)	ros2/geometry2#762
test_tf2	6 - test_static_publisher.launch.py (Failed)	ros2/geometry2#762
tf2_ros	5 - test_buffer (Failed)	ros2/geometry2#762
tf2_ros	9 - tf2_ros_test_transform_listener (Failed)	ros2/geometry2#762
tf2_ros	10 - tf2_ros_test_static_transform_broadcaster (Failed)	ros2/geometry2#762
tf2_ros	11 - tf2_ros_test_transform_broadcaster (Failed)	ros2/geometry2#762
tf2_ros	12 - tf2_ros_test_time_reset (Failed)	ros2/geometry2#762
tf2_ros	14 - tf2_ros_test_listener (Failed)	ros2/geometry2#762

2025-03-04 Update

• TLS Bugfixes:
  • fix: add rclcpp::shutdown rviz#1343
  • fix: add rclcpp::shutdown message_filters#167
  • fix: add rclcpp::shutdown geometry2#762
  • fix: add rclcpp::shutdown ros-perception/image_common#347
  • fix: add rclcpp::shutdown ros-perception/point_cloud_transport#110
• Remove the failures in composition package since it's not reproducible.
• Sort by priority.
• Remove "demo_nodes_cpp_native/1 - test_tutorial_talker" since it only supports rmw_fastrtps_cpp

[JEnoch]

Note: "TLS Issue" refers to the issue with Thread Local Storage discussed in #170.
The fix is to ensure to call rclcpp::shutdown() when a test exits, as recommended in README.md

[Yadunund]

@YuanYuYuan please run tests using this ros2.repos file: ros2/ros2#1649

Also you can leave fixing test_rmw_implementation to me!

[YuanYuYuan]

@YuanYuYuan please run tests using this ros2.repos file: ros2/ros2#1649

Sure.

Also you can leave fixing test_rmw_implementation to me!

Thanks 🙂

[ahcorde]

More failing tests:

name	list	reason
test_rmw_implementation	53 - test_subscription__rmw_zenoh_cpp (Failed)	Related issue #496
test_rmw_implementation	64 - test_event__rmw_zenoh_cpp (Failed)	matched_status.current_count_change

[Yadunund]

@YuanYuYuan could we update the table above to strikeout the tests that have been fixed?

[YuanYuYuan]

Let me update the table here.

name	list	reason
rosbag2_transport	1 - test_play__rmw_zenoh_cpp (Timeout)	#510
test_rmw_implementation	5 - test_subscription__rmw_zenoh_cpp (Failed)	value of taken actual: true, expected: false

[Yadunund]

test_rmw_implementation has been resolved #481

Remaining test failures:

name	list	reason
rosbag2_transport	1 - test_play__rmw_zenoh_cpp (Timeout)	#510
rosbag2_transport	1 - test_record_all__rmw_zenoh_cpp (Failed)	#520

[YuanYuYuan]

Some pytest failures were not caught last time. Here's the update.

package	reason
ros2action	issue: RUST_LOG
ros2lifecycle	issue: RUST_LOG
ros2param	issue: RUST_LOG
ros2doctor	ros2/ros2cli#985
ros2node	#536
ros2service	#536
ros2topic	#523
sros2	issue: ros2 security generate_policy: error

• The RUST_LOG issue means some tests fail because the Rust debugging log (which is usually enabled by setting export RUST_LOG=info) interferes with the output log and thus mismatches the expected output.

[Yadunund]

@YuanYuYuan and @ahcorde what the the remaining test failures you are observing?

[YuanYuYuan]

@YuanYuYuan and @ahcorde what the the remaining test failures you are observing?

On Ubuntu rolling, everything is fine except for the sros2.
I'm testing on Windows rolling.

[Yadunund]

@YuanYuYuan could we open a ticket with more details on the sros2 failures?

[YuanYuYuan]

@YuanYuYuan could we open a ticket with more details on the sros2 failures?

No worries. The error log said "connection refused", which is different from the one I saw last time. The test can pass if we run it individually.