Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse parameter descriptors in yaml #533

Open
wants to merge 19 commits into
base: rolling
Choose a base branch
from
Open

Parse parameter descriptors in yaml #533

wants to merge 19 commits into from

Commits on Jun 25, 2021

  1. add param_descriptor type 

    Signed-off-by: Brian Wilcox <[email protected]>
    @bpwilcox
    bpwilcox committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    2185043 View commit details
    Browse the repository at this point in the history

  2. add parameter descriptors map level and namespace key 

    Signed-off-by: Brian Wilcox <[email protected]>
    @bpwilcox
    bpwilcox committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    d5712fd View commit details
    Browse the repository at this point in the history

  3. add param descriptor copy and deallocation 

    Signed-off-by: Brian Wilcox <[email protected]>
    @bpwilcox
    bpwilcox committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    2ab8f09 View commit details
    Browse the repository at this point in the history

  4. add node_params_descriptors init and re/deallocation 

    Signed-off-by: Brian Wilcox <[email protected]>
    @bpwilcox
    bpwilcox committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    f337a6a View commit details
    Browse the repository at this point in the history

  5. add find_descriptor, parse_desriptor, and modify parse file events an… 

    …d parse key for descriptor map level

Signed-off-by: Brian Wilcox <[email protected]>
    @bpwilcox
    bpwilcox committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    702c448 View commit details
    Browse the repository at this point in the history

  6. modify replace ns with parameter descriptor level 

    Signed-off-by: Brian Wilcox <[email protected]>
    @bpwilcox
    bpwilcox committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    817bce1 View commit details
    Browse the repository at this point in the history

  7. modify parser implementation for parameter descriptors, add get param… 

    … descriptor struct API

Signed-off-by: Brian Wilcox <[email protected]>
    @bpwilcox
    bpwilcox committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    2640d09 View commit details
    Browse the repository at this point in the history

  8. add new files to CMakeLists 

    Signed-off-by: Brian Wilcox <[email protected]>
    @bpwilcox
    bpwilcox committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    b299ff2 View commit details
    Browse the repository at this point in the history

  9. check for new map at MAP_NODE_NAME_LVL: fixes issue to allow both par… 

    …ameters and descriptors under node name in yaml

Signed-off-by: Brian Wilcox <[email protected]>
    @bpwilcox
    bpwilcox committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    ce49272 View commit details
    Browse the repository at this point in the history

  10. fix test now that more calloc calls with param descriptors 

    Signed-off-by: Brian Wilcox <[email protected]>
    @bpwilcox
    bpwilcox committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    7836801 View commit details
    Browse the repository at this point in the history

  11. add parameter descriptor yaml tests 

    Signed-off-by: Brian Wilcox <[email protected]>
    @bpwilcox
    bpwilcox committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    9da5590 View commit details
    Browse the repository at this point in the history

  12. add parameter to test yaml for extra coverage and verify parsed param… 

    … outputs

Signed-off-by: Brian Wilcox <[email protected]>
    @bpwilcox
    bpwilcox committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    0b8a5d7 View commit details
    Browse the repository at this point in the history

  13. add unit tests for param descriptors 

    Signed-off-by: Brian Wilcox <[email protected]>
    @bpwilcox
    bpwilcox committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    c06b47a View commit details
    Browse the repository at this point in the history

  14. fix cpplint 

    Signed-off-by: Brian Wilcox <[email protected]>
    @bpwilcox
    bpwilcox committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    dbfbe87 View commit details
    Browse the repository at this point in the history

  15. fix uncrustify issues 

    Signed-off-by: Brian Wilcox <[email protected]>
    @bpwilcox
    bpwilcox committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    f5338cc View commit details
    Browse the repository at this point in the history

  16. change param descriptor key name to ros__parameter_descriptors 

    Signed-off-by: Brian Wilcox <[email protected]>
    @bpwilcox
    bpwilcox committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    a5939aa View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2021

  1. remove error msg for node name before key to allow for both keys para… 

    …m/descriptor keys under node name

Signed-off-by: Brian Wilcox <[email protected]>
Signed-off-by: Brian <[email protected]>
    @bpwilcox
    bpwilcox committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    e6cf65d View commit details
    Browse the repository at this point in the history

  2. address feedback, remove descriptor name, change field naming 

    Signed-off-by: Brian <[email protected]>
    @bpwilcox
    bpwilcox committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    1d1eb27 View commit details
    Browse the repository at this point in the history

  3. add dynamic_typing field 

    Signed-off-by: Brian <[email protected]>
    @bpwilcox
    bpwilcox committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    a66f54d View commit details
    Browse the repository at this point in the history