Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove references to installing cargo-ament-build via cargo #442

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

esteve
Copy link
Collaborator

@esteve esteve commented Dec 4, 2024

Now that cargo-ament-build is avaialble via PyPI as a Python wheel and that cargo-ros-cargo depends on it, we can install both in one go.

@jhdcs jhdcs merged commit f706824 into ros2-rust:main Dec 4, 2024
6 checks passed
@esteve esteve deleted the pip-install-cargo-ros-cargo branch December 4, 2024 13:40
@luca-della-vedova
Copy link
Collaborator

Ah this all happened while I was sleeping 😅

I guess this is OK for now but I would have argued that we will actually need to do the opposite soon, since installing pip packages in Jazzy / 24.04 is very painful, and it is unclear whether we will be able to package cargo-ament-build as a debian package.
I suspect the final intermediate solution will be to revert this and actually install cargo-ament-build from cargo and let apt manage the colcon extensions instead

@esteve
Copy link
Collaborator Author

esteve commented Dec 5, 2024

I don't think that would be necessary, the cargo-ament-build Python wheel could be distributed as a Debian package as is, as a precompiled binary and we wouldn't need to worry about the intermediate solution you describe.

For me, the ideal solution would be to mimic what the ruff Debian package does.

@mxgrey
Copy link
Collaborator

mxgrey commented Dec 5, 2024

If the precompiled binary can be distributed as-is through debian then that's definitely the best case scenario.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants