-
Notifications
You must be signed in to change notification settings - Fork 9
Proposal for simulation interfaces #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mjcarroll
merged 33 commits into
ros-simulation:main
from
adamdbrw:simulation_interfaces
Mar 21, 2025
Merged
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
5267ea2
simulation interfaces
adamdbrw 0cfd0fd
Apply suggestions from code review
adamdbrw d874c23
applied review suggestions
adamdbrw 10f59d2
added missing cmake entries
adamdbrw ea23f59
stepping service
adamdbrw 97b79f7
robot_namespace -> namespace
adamdbrw 8bae938
changed filter semantics to regex
adamdbrw 885a3fa
Updated EntityState and SpawnableBounds messages to address feedback
adamdbrw 53d6ee9
Added action for multi-stepping
adamdbrw aaee904
Added stepping alternatives documentation
adamdbrw df98b24
Added GetSimulatorFeatures interface
adamdbrw 4d551f1
Apply suggestions from code review
adamdbrw 95f46d9
Update srv/GetEntityState.srv
adamdbrw 0169e10
Code review improvements:
adamdbrw 1e92784
Apply suggestions from code review
adamdbrw 9bf757f
Revision following the review:
adamdbrw e94797f
Added sources field; documentation changes
adamdbrw eabed90
Update action/MultiStepSimulation.action
adamdbrw 271a8a1
Modified result handling and entity info, tags and categories
adamdbrw 9ec77e6
Apply suggestions from code review
adamdbrw 86ea8e0
Addressing review:
adamdbrw 9d123ed
Addressing review comments:
adamdbrw a940c65
Review comments applied:
adamdbrw aee7e79
Update msg/SimulationState.msg
adamdbrw 4497cbc
Apply suggestions from code review
adamdbrw af3ebff
Applied review comments:
adamdbrw 5f0aefb
corrected entities to strings
adamdbrw 5fe0d30
Update msg/Bounds.msg
adamdbrw eb6f27e
Applied review
adamdbrw e98721f
Applied review
adamdbrw 65a653f
feature naming fix
adamdbrw 4e6867d
Update srv/SetEntityState.srv
adamdbrw 2206c58
Update srv/SetEntityState.srv
adamdbrw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,16 @@ | ||
# Entity major category, which often warrants a specific way to handle such entity, e.g. when handling humans | ||
# or mapping persistence for dynamic vs static objects. | ||
|
||
uint8 OBJECT = 0 # Generic or unspecified type. | ||
uint8 ROBOT = 1 # A broad category for mobile robots, arms, drones etc., usually with ROS 2 interfaces. | ||
uint8 HUMAN = 2 # Simulated humans, e.g. pedestrians, warehouse workers. Compared to DYNAMIC_OBJECT category, | ||
# humans are often expected to be treated exceptionally in regards to safety constraints. | ||
uint8 DYNAMIC_OBJECT = 4 # Vehicles, animals, mobile obstacles, typically to present a detection & tracking challenge, | ||
# such as when simulation is used to test robot perception or navigation stack. | ||
uint8 STATIC_OBJECT = 5 # Any object which is static, e.g. not supposed to change its pose | ||
# unless by means of SetEntityState. | ||
uint8 CATEGORY_OBJECT = 0 # Generic or unspecified type. | ||
uint8 CATEGORY_ROBOT = 1 # A broad category for mobile robots, arms, drones etc., | ||
# usually with ROS 2 interfaces. | ||
uint8 CATEGORY_HUMAN = 2 # Simulated humans, e.g. pedestrians, warehouse workers. | ||
# Compared to CATEGORY_DYNAMIC_OBJECT, humans are often expected to be treated | ||
# exceptionally in regards to safety constraints. | ||
uint8 CATEGORY_DYNAMIC_OBJECT = 4 # Vehicles, animals, mobile obstacles, typically to present a detection and | ||
# tracking challenge, such as when simulation is used to test robot perception | ||
# or navigation stack. | ||
uint8 CATEGORY_STATIC_OBJECT = 5 # Any object which is static, e.g. not supposed to change its pose | ||
# unless by means of SetEntityState. | ||
|
||
uint8 category |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,18 @@ | ||
# Result code and message for service calls. | ||
adamdbrw marked this conversation as resolved.
Show resolved
Hide resolved
|
||
# Note that additional results for specific services can defined within them using values above 100. | ||
|
||
uint8 FEATURE_UNSUPPORTED = 0 # Feature is not supported by the simulator, check GetSimulatorFeatures. | ||
# While feature support can sometimes be deduced from presence of corresponding | ||
# service / action interface, in other cases it is about supporting certain call | ||
# parameters, formats and options within interface call. | ||
uint8 OK = 1 | ||
uint8 NOT_FOUND = 2 # No match for input (such as when entity name does not exist). | ||
uint8 INCORRECT_STATE = 3 # Simulator is in an incorrect state for this interface call, e.g. a service | ||
# requires paused state but the simulator is not paused. | ||
uint8 OPERATION_FAILED = 4 # Request could not be completed successfully even though feature is supported and | ||
# the input is correct; check error_message for details. | ||
# Implementation rule: check extended codes for called service (e.g. SpawnEntity) | ||
# to provide a return code which is more specific. | ||
uint8 RESULT_FEATURE_UNSUPPORTED = 0 # Feature is not supported by the simulator, check GetSimulatorFeatures. | ||
# While feature support can sometimes be deduced from presence of corresponding | ||
# service / action interface, in other cases it is about supporting certain | ||
# call parameters, formats and options within interface call. | ||
uint8 RESULT_OK = 1 | ||
uint8 RESULT_NOT_FOUND = 2 # No match for input (such as when entity name does not exist). | ||
uint8 RESULT_INCORRECT_STATE = 3 # Simulator is in an incorrect state for this interface call, e.g. a service | ||
# requires paused state but the simulator is not paused. | ||
uint8 RESULT_OPERATION_FAILED = 4 # Request could not be completed successfully even though feature is supported | ||
# and the input is correct; check error_message for details. | ||
# Implementation rule: check extended codes for called service | ||
# (e.g. SpawnEntity) to provide a return code which is more specific. | ||
|
||
uint8 result # Result to be checked on return from service interface call | ||
string error_message # Additional error description when useful. | ||
uint8 result # Result to be checked on return from service interface call | ||
string error_message # Additional error description when useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamdbrw marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamdbrw marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.