Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Magic number in getConversionCodes() #532

Open
galou opened this issue May 6, 2024 · 2 comments · May be fixed by #540
Open

Magic number in getConversionCodes() #532

galou opened this issue May 6, 2024 · 2 comments · May be fixed by #540

Comments

@galou
Copy link

galou commented May 6, 2024

There is a magic 5 in getConversionCodes(). Shouldn't it actually be 10, the last index of the Encoding enum?

Anyway, a comment should be added explaining the number there.
@ijnek ijnek linked a pull request Nov 16, 2024 that will close this issue
Open
@ijnek
Copy link
Member

ijnek commented Nov 16, 2024

Sorry it took so long to get a response on this issue - you're right, it should be 10.

@galou
Copy link
Author

galou commented Nov 22, 2024

Thanks for the fix! Time does not matter. You didn't get paid for it I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ensure same format encoding happens for all encoded types ijnek/vision_opencv
2 participants
@galou @ijnek