Disable unstable system test in Travis. #527
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
disablesystemtest
branch
from
41c6084 to
c753747
Compare
mhpanah
approved these changes
Jan 22, 2019
Merged
|
Looks like I was too quick to blame the test. Looks like we're getting this failure due to a change in the underlying ROS 2 library. Thanks @mkhansen-intel for finding this. Certain nodes are throwing an exception: This is likely the root cause of the high failure rate. I'm closing this PR. We'll fix the underlying problem first. |
ghost
closed this
|
I filed a bug here: ros2/rcl#375 |
ghost
mentioned this pull request
mini-1235
pushed a commit
to mini-1235/navigation2
that referenced
this pull request
Feb 5, 2025
Forsyth-Creations
pushed a commit
to Forsyth-Creations/navigation2
that referenced
this pull request
Feb 19, 2025
* Use RT buffer for gripper action controller's goal handle * fix format --------- Co-authored-by: Bence Magyar <[email protected]>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The system test is failing far more often than the 1% predicted. This is causing PRs and the master branch to show they are failing even though the fault is not part of that change.
This change disables the system test until it can be made more stable