Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "license-org" and "license-text" parameters #298

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add "license-org" and "license-text" parameters #298

wants to merge 2 commits into from

Conversation

JasonShigit
Copy link

If "license-org" and license-text" are passing in command line, the default value will be overlayed in generated files.

@JasonShigit
Copy link
Author

@allenh1 Could you please review and comment?
Test pass with my meta-ros env.

@JasonShigit
Add "license-org" and "license-text" parameters
6819008 
If "license-org" and license-text" are passing in command line, the
default value will be overlayed in generated files.

Signed-off-by: Jason Shi <[email protected]>
@allenh1
Copy link
Contributor

allenh1 commented May 31, 2023

@JasonShigit sorry for the delay! I'm running CI on it now.

allenh1
allenh1 previously approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@allenh1 allenh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@JasonShigit
Copy link
Author

Hi @allenh1
Thanks for help. The test failed and i updated one more change for test_ebuild.py. Is there any guidance for running tests locally?

@allenh1
Copy link
Contributor

allenh1 commented Jun 6, 2023 •
edited
Loading

@JasonShigit it seems there are still a few errors to resolve.

The best way to run locally is to install all the requirements (see requirements.txt), and run pytest.

@robwoolley
Copy link
Contributor

Thanks for submitting this. Can you describe the use case for allowing superflore to generate recipes under a difference license?

Since the recipes are generated based on metadata, I am skeptical whether they can be copyrighted in the first place. Moreover the default copyright used for bitbake recipes is MIT and this patch would change the default to BSD.

If you can describe the reason for this change it will help me better understand why it is needed. I think before I could merge this in, I would need to run it by the OSRA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allenh1 allenh1 allenh1 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JasonShigit @allenh1 @robwoolley