Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'sles' using the "OS_OPENSUSE" tag #255

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

neotinker
Copy link
Contributor

@neotinker neotinker commented Jul 5, 2022

With the release of SLES 15 SP3, OpenSUSE and SUSE Linux Enterprise Server now share a common code base and are 100% binary compatible.Since the work has already been done to support OpenSUSE, lets just treat SLES as if it is OpenSUSE to reduce duplicated effort.

https://www.suse.com/c/introducing-suse-linux-enterprise-15-sp3/#:~:text=With%20the%20release%20of%20SLES,again%20%E2%80%93%20with%20assured%20application%20compatibility.

neotinker@ros-sles153:~/devel> cat /etc/os-release 
NAME="SLES"
VERSION="15-SP3"
VERSION_ID="15.3"
PRETTY_NAME="SUSE Linux Enterprise Server 15 SP3"
ID="sles"
ID_LIKE="suse"
ANSI_COLOR="0;32"
CPE_NAME="cpe:/o:suse:sles:15:sp3"
DOCUMENTATION_URL="https://documentation.suse.com/"
neotinker@ros-sles153:~/devel> 

Copy link
Member

@cottsay cottsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I'd rather see us add a new OS ID for SLES and then perform an alias in rosdep like we do for Ubuntu and RHEL derivatives. Better to give more specific information here.

@cottsay
Copy link
Member

cottsay commented Feb 12, 2024

Friendly ping. If you're not interested in pushing this forward, we should close this PR.

@neotinker
Copy link
Contributor Author

Honestly, since I opened this PR, the direction of SLES has become less clear. It is probably best not to mix the two.

@cottsay
Copy link
Member

cottsay commented Feb 16, 2024

Honestly, since I opened this PR, the direction of SLES has become less clear. It is probably best not to mix the two.

All the more reason to add a new OS ID here. We can decide whether to "alias" the distro in rosdep, but this is the first step regardless of whether SLES is an alias of OpenSUSE or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants