Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up script entry points #185

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Clean up script entry points #185

merged 1 commit into from
Jun 28, 2024

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Jun 28, 2024 •
edited
Loading

Two factors here:

  1. Ensure that each script has an explicit main() function
  2. Ensure that the return value of main() is the return value of the program when the script is invoked directly.

@cottsay
Clean up script entry points
48c6be5 
Two factors here:
1. Ensure that each script has an exlicit main() function
2. Ensure that the return value of main() is the return value of the
   program when the script is invoked directly.
@cottsay cottsay requested a review from nuclearsandwich June 28, 2024 15:04
@cottsay cottsay self-assigned this Jun 28, 2024
@cottsay cottsay mentioned this pull request Jun 28, 2024
Merged
christophebedard
christophebedard approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

I'm seeing a bit of a mix of single and double quotes, but that's probably outside of the scope of this PR.

@cottsay
Copy link
Member Author

cottsay commented Jun 28, 2024

I'm seeing a bit of a mix of single and double quotes, but that's probably outside of the scope of this PR.

There's actually no flake8 check on this repo at all. There are a LOT of deviations and inconsistencies...

@cottsay cottsay merged commit 6015280 into master Jun 28, 2024
18 checks passed
@cottsay cottsay deleted the cottsay/script-mains branch June 28, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophebedard christophebedard christophebedard approved these changes

@nuclearsandwich nuclearsandwich nuclearsandwich approved these changes

Assignees

@cottsay cottsay

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cottsay @nuclearsandwich @christophebedard