Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make path operations and conversions portable in tests #177

Merged
merged 2 commits into from
May 3, 2024
Merged

Make path operations and conversions portable in tests #177

merged 2 commits into from
May 3, 2024

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented May 1, 2024

Two classes of issues:

  1. Use os.path.join instead of string concatenation
  2. Use urljoin/pathname2url to create file:// URLs

@cottsay cottsay self-assigned this May 1, 2024
@cottsay cottsay added the bug label May 1, 2024
@cottsay cottsay merged commit 5857d99 into master May 3, 2024
13 checks passed
@cottsay cottsay deleted the cottsay/path-url-conversions branch May 3, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claraberendsen claraberendsen claraberendsen approved these changes

@nuclearsandwich nuclearsandwich nuclearsandwich approved these changes

Assignees

@cottsay cottsay

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cottsay @nuclearsandwich @claraberendsen