Teach rosdep to use ROS_VERSION when resolving conditionals #941
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metadata from REP153 includes the
ROS_PYTHON_VERSION
, which is currently cached during a call torosdep update
so that it is available to package manifest conditionals during rosdep operations in an environment whereROS_PYTHON_VERSION
is not already set.This change extends that metadata caching to include the
ROS_VERSION
variable as well. These two values combined withROS_DISTRO
, are the three variables supplied by Bloom during manifest conditional evaluation. It makes sense to treat them the same way here.Reproduction:
$ git clone https://github.com/autowarefoundation/tvm_vendor.git
(or any package which usesROS_VERSION
)$ rosdep keys --rosdistro humble --from-path tvm_vendor
Expected results:
Actual results: