Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pkg_resources deprecated warning #926

Merged
merged 7 commits into from
Apr 11, 2024
Merged

fix: pkg_resources deprecated warning #926

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7d19c8d
fix: pkg_resources deprecated warning
Aug 7, 2023
65330c2
use importlib_metadata for RHEL (py3.6)
Aug 8, 2023
68af596
remove setuptools dependency, not deeded anymore
Aug 17, 2023
02c3fb8
add comment on keeping the "setuptools" naming
Aug 17, 2023
be547a7
Merge branch 'master' into fix/deprecation_pkg_resources
cottsay Apr 9, 2024
dbba2d2
Merge branch 'master' into fix/deprecation_pkg_resources
Apr 11, 2024
e09aa94
add test for pip get_version_strings
Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/rosdep2/platforms/pip.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@

from __future__ import print_function

import importlib.metadata
SubaruArai marked this conversation as resolved.
Show resolved Hide resolved
import os
import pkg_resources
import subprocess
import sys

Expand Down Expand Up @@ -130,8 +130,8 @@ def __init__(self):
super(PipInstaller, self).__init__(pip_detect, supports_depends=True)

def get_version_strings(self):
pip_version = pkg_resources.get_distribution('pip').version
setuptools_version = pkg_resources.get_distribution('setuptools').version
pip_version = importlib.metadata.version('pip')
setuptools_version = importlib.metadata.version('setuptools')
version_strings = [
'pip {}'.format(pip_version),
'setuptools {}'.format(setuptools_version),
Expand Down