Introduce notion of "experimental" build types. #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When per build type templates were introduced for ROS 2 support, little thought was given to how the number of build types might expand in the future. I think that there's good fodder for a rethink of the build type handling in general, but in the meantime I would like to introduce this concept and a small warning to signify the possibility that these new build types are outside the focus of the core infrastructure team. The initial criteria for a build type being "experimental" is that it's novel. Criteria for graduating from an experimental build type to normal one is not currently settled.
This addition pauses generation on the experimental build type and prompts the user to continue each time. Defaulting to yes is intentional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When per build type templates were introduced for ROS 2 support, little thought was given to how the number of build types might expand in the future. I think that there's good fodder for a rethink of the build type handling in general, but in the meantime I would like to introduce this concept and a small warning to signify the possibility that these new build types are outside the focus of the core infrastructure team.
The initial criteria for a build type being "experimental" is that it's novel.
Criteria for graduating from an experimental build type to normal one is not currently settled.