Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove wrong comments #240

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Remove wrong comments #240

merged 1 commit into from
Dec 19, 2024

Conversation

christophfroehlich
Copy link
Contributor

copy-pasta

@christophfroehlich christophfroehlich added the backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS 2 humble. label Dec 18, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.16%. Comparing base (70d93ba) to head (999fcd9).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #240   +/-   ##
=======================================
  Coverage   73.16%   73.16%           
=======================================
  Files           7        7           
  Lines         436      436           
  Branches       72       72           
=======================================
  Hits          319      319           
  Misses         73       73           
  Partials       44       44
Flag Coverage Δ
unittests 73.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
include/realtime_tools/realtime_buffer.hpp 79.54% <ø> (ø)

bmagyar
bmagyar approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also not a nice text

@bmagyar bmagyar merged commit 246e57e into master Dec 19, 2024
19 checks passed
@bmagyar bmagyar deleted the fix/comments branch December 19, 2024 06:43
mergify bot pushed a commit that referenced this pull request Dec 19, 2024
@christophfroehlich @mergify
Remove wrong comments (#240)
a7ed8a0 
(cherry picked from commit 246e57e)
@mergify mergify bot mentioned this pull request Dec 19, 2024
Merged
christophfroehlich added a commit that referenced this pull request Dec 19, 2024
@mergify @christophfroehlich
Remove wrong comments (backport #240) (#242)
e9140b8 
Remove wrong comments (#240)

(cherry picked from commit 246e57e)

Co-authored-by: Christoph Fröhlich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikishor saikishor saikishor approved these changes

@bmagyar bmagyar bmagyar approved these changes

@aprotyas aprotyas Awaiting requested review from aprotyas

@harderthan harderthan Awaiting requested review from harderthan

@mhubii mhubii Awaiting requested review from mhubii

@olivier-stasse olivier-stasse Awaiting requested review from olivier-stasse

@progtologist progtologist Awaiting requested review from progtologist

Assignees
No one assigned
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS 2 humble.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@christophfroehlich @codecov-commenter @bmagyar @saikishor