Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate wf #230

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Remove duplicate wf #230

merged 1 commit into from
Dec 10, 2024

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Dec 10, 2024

Mistake with #217

@christophfroehlich christophfroehlich added the backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS 2 humble. label Dec 10, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.72%. Comparing base (81afa50) to head (99be1b2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #230   +/-   ##
=======================================
  Coverage   72.72%   72.72%           
=======================================
  Files           7        7           
  Lines         429      429           
  Branches       71       71           
=======================================
  Hits          312      312           
  Misses         73       73           
  Partials       44       44           
Flag Coverage Δ
unittests 72.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.
Thanks for fixing it

@saikishor saikishor merged commit e74a882 into master Dec 10, 2024
19 checks passed
@saikishor saikishor deleted the ci/cleanup branch December 10, 2024 22:35
mergify bot pushed a commit that referenced this pull request Dec 10, 2024
(cherry picked from commit e74a882)

# Conflicts:
#	.github/workflows/binary-downstream-build.yml
christophfroehlich added a commit that referenced this pull request Dec 11, 2024
Remove duplicate downstream build workflow (#230)

Co-authored-by: Christoph Fröhlich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS 2 humble.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants