Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt API style of lock_memory to match the one of the other functions (backport #209) #229

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Dec 9, 2024

This PR adapts the API style of the lock_memory function to match the style of the other methods.

I will create a PR that adapts the usage in ros2 control:
https://github.com/search?q=repo%3Aros-controls%2Fros2_control%20lock_memory&type=code

Which is also the only place it is currently used:
https://github.com/search?q=realtime_tools%3A%3Alock_memory&type=code


This is an automatic backport of pull request #209 done by Mergify.

#209)

Co-authored-by: Lennart Nachtigall <[email protected]>
(cherry picked from commit 069df6d)
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 76.15%. Comparing base (397209c) to head (7659aed).

Files with missing lines Patch % Lines
src/realtime_helpers.cpp 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           humble     #229      +/-   ##
==========================================
- Coverage   77.28%   76.15%   -1.14%     
==========================================
  Files           8        8              
  Lines         471      478       +7     
  Branches      179      183       +4     
==========================================
  Hits          364      364              
- Misses         70       77       +7     
  Partials       37       37              
Flag Coverage Δ
unittests 76.15% <0.00%> (-1.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/realtime_helpers.cpp 44.23% <0.00%> (-3.20%) ⬇️

@christophfroehlich christophfroehlich merged commit 14293a6 into humble Dec 10, 2024
11 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/humble/pr-209 branch December 10, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants