Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API of RealtimeBox is broken #200

Open
4 tasks
christophfroehlich opened this issue Nov 23, 2024 · 0 comments · May be fixed by #202
Open
4 tasks

API of RealtimeBox is broken #200

christophfroehlich opened this issue Nov 23, 2024 · 0 comments · May be fixed by #202
Labels

Comments

@christophfroehlich
Copy link
Contributor

christophfroehlich commented Nov 23, 2024

the deprecation failed, things to fix

  • The set/get method is not compatible any more, @saikishor has an idea
  • received_velocity_msg_ptr_.set(nullptr); like we used in diff_drive_controller now builds but throws C++ exception with description "bad_function_call" thrown in the test body. at runtime
  • the realtime_box_best_effort.h is not available any more -> add it again pointing to the new one with a deprecation warning
  • add downstream builds to a CI job to be more aware of API breaking changes Add downstream build CI job #201

Not sure if we can fix that for the humble releases, or we have to revert that and branch for rolling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant