Add a test template for plugin implementations #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
Maverobot,
aprotyas,
bmagyar,
fmauch,
harderthan,
qiayuanl and
saikishor
|
This pull request is in conflict. Could you fix it @christophfroehlich? |
christophfroehlich
force-pushed
the
test/template
branch
from
8e21779 to
7a9ce64
Compare
|
This pull request is in conflict. Could you fix it @christophfroehlich? |
|
This pull request is in conflict. Could you fix it @christophfroehlich? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test cases are independent of the implementation, and all implementations should succeed with the tests.
I haven't touched the testcases itself, only moved it to a header file which is installed as INTERFACE library if BUILD_TESTING is true.
Maybe we should install it always, so that the header file is shipped with binaries from the buildfarm and users of custom plugins could use it?