-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BETY cleanup #88
BETY cleanup #88
Conversation
Security issue! When passed in ..., username and password were treated as query arguments and appended to the URL. Fixed by adding them as named arguments.
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
=========================================
Coverage ? 12.98%
=========================================
Files ? 14
Lines ? 716
Branches ? 0
=========================================
Hits ? 93
Misses ? 623
Partials ? 0
Continue to review full report at Codecov.
|
@infotroph sure, i'll have a look |
Using options makes sense to me - I'll defer to the ropensci conventions &
best practices
…On Fri, Feb 24, 2017 at 4:01 PM Scott Chamberlain ***@***.***> wrote:
@infotroph <https://github.com/infotroph> sure, i'll have a look
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#88 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAcX5w1pyR_tqgePBLIMRvt7m47v-yKrks5rf1MqgaJpZM4MLdQH>
.
|
in the future it'd be easier to deal with smaller PR's - this isn't huge, but does encompass things that at least to me could be done separately. Looks okay to me for now. we'll see later if it leads to any problems, travis is passing, so that's a good sign |
@sckott sorry for the huge pull -- I'm making a note to keep them smaller in the future. This can be merged now and I'll submit deprecation changes separately iff we go forward with them. |
thanks @infotroph |
added (Chris Black) (@infotroph) to author list based on contributions to the betydb interface (especially ropensci#94, ropensci#88, ropensci#82)
Dealing with bits from the BETY API version update that weren't finished in #82.
options("betydb_url")
etc overlist(url, version, key, ...)
because it appears to be more in line with how auth is handled in other ropensci packages.test_that
, which turns out to be more complicated than I expected. See any lurking bugs?betydb_query
acceptsinclude_unchecked
,limit
, andoffset
(Add option to retrieve 'unchecked' data from BETYdb #52 )betydb_record
now provides a generic replacement, sobetydb_<table>(id)
is now ~equivalent tobetydb_record(id, table=<table>)
.betydb_<table>
callbetydb_record
to get the full possibly-nested list, then apply whatever table-specific formatting is needed to return a standardized dataframe.