Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for filter_id. closes #224 #331

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aaronball85
Copy link

This adds a filter_id argument for fetch_survey(). I've updated the code and documentation to reflect the change. Changes passed package tests. Also, I've tested the functionality with a filterId that I created with a Qualtrics survey and it worked as expected. Let me know what you think. Thanks!

@juliasilge
Copy link
Collaborator

Thanks for your patience with us getting to you on this @aaronball85! We will need to get the tests updated in this PR as well. @jmobrien outlined some of what needs to happen here. Would you be able to take a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants