Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tests #163

Merged
merged 9 commits into from
Jan 13, 2025
Merged

fix tests #163

merged 9 commits into from
Jan 13, 2025

Conversation

dpprdan
Copy link
Member

@dpprdan dpprdan commented Dec 26, 2024

This PR updates/fixes tests:

  1. use examples from Brest instead of Nantes, because some examples don't work anymore due to changes in the OpenCage responses, cf. issue with address_only? #160
  2. update vignettes to changed API responses
  3. remove tests w.r.t. min_confidence, cf. no results with limit=1 and min_confidence=7 #161, (this is the first part of drop min_confidence #162)
  4. update snapshots

The style workflow is fixed in #164.

@dpprdan dpprdan requested a review from maelle December 26, 2024 20:58
@dpprdan dpprdan self-assigned this Dec 26, 2024
@dpprdan dpprdan mentioned this pull request Dec 27, 2024
@dpprdan dpprdan marked this pull request as draft December 28, 2024 20:45
@dpprdan
Copy link
Member Author

dpprdan commented Dec 28, 2024

Turns out some API responses used in the vignettes changed as well, so I'll update those first, hoping we'll have less diff clutter when doing code changes.

e.g. `q=Berlin, limit=5` returns only one result, making that example useless.
also the hotel de ville in Nantes example isn't working anymore, see #160
@dpprdan
Copy link
Member Author

dpprdan commented Dec 31, 2024

The examples in the vignettes should be fine again.

@dpprdan dpprdan marked this pull request as ready for review December 31, 2024 11:19
Copy link
Member

@maelle maelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dpprdan
Copy link
Member Author

dpprdan commented Jan 13, 2025

We're ready to merge then, @maelle?
(I was looking for some "@maelle approved" message, but maybe I'm confusing the GitHub with the GitLab UI? 😕)

Update: looking at past PRs I can confirm that I am the confused one. 😬 Nevermind then! 😄

@dpprdan dpprdan merged commit 07134ce into main Jan 13, 2025
7 of 8 checks passed
@dpprdan dpprdan deleted the fix_tests branch January 13, 2025 12:31
@maelle
Copy link
Member

maelle commented Jan 13, 2025

I think I could have approved, I only commented because it seemed preposterous to give approval somehow, as you're the maintainer and know best! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants