-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix tests #163
Conversation
because some examples don't work anymore, cf. #160
presumably due to changes in {testthat}
Turns out some API responses used in the vignettes changed as well, so I'll update those first, hoping we'll have less diff clutter when doing code changes. |
e.g. `q=Berlin, limit=5` returns only one result, making that example useless. also the hotel de ville in Nantes example isn't working anymore, see #160
The examples in the vignettes should be fine again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
I think I could have approved, I only commented because it seemed preposterous to give approval somehow, as you're the maintainer and know best! 😁 |
This PR updates/fixes tests:
address_only
? #160min_confidence
, cf. no results withlimit=1
andmin_confidence=7
#161, (this is the first part of dropmin_confidence
#162)The style workflow is fixed in #164.