[CI] Don't upload build caches to S3 for Mac15 and Mac26. #20113
Conversation
The source and build caches aren't used since 4c3335e, so there is no urgent need to generate them at all. Since the Mac VMs sometimes hang for several hours at the upload step, it seems less fragile to not upload or download anything.
hageboeck
force-pushed
the
upload_macVM
branch
from
baff6a8 to
04d2dfc
Compare
Test Results 22 files 22 suites 3d 15h 2m 32s ⏱️ Results for commit 9e34c62. ♻️ This comment has been updated with latest results. |
hageboeck
force-pushed
the
upload_macVM
branch
2 times, most recently
from
5f796ea to
3aabb95
Compare
hageboeck
force-pushed
the
upload_macVM
branch
from
3aabb95 to
9e34c62
Compare
| ${{ (github.event_name != 'schedule' && github.event_name != 'workflow_dispatch' && join( matrix.overrides, ', ' )) || '' }} | ||
| steps: | ||
| - name: Node state |
There was a problem hiding this comment.
Is this step meant to be merged?
There was a problem hiding this comment.
Yes, we would like to add some diagnostics for the node to the CI runs.
| shell: bash -leo pipefail {0} | ||
| if: github.event_name == 'push' | ||
| run: ".github/workflows/root-ci-config/build_root.py | ||
| if: ${{ github.event_name == 'push' && !matrix.platform == 'mac15' && !matrix.platform == 'mac26' }} |
There was a problem hiding this comment.
Is there a way to link/relate closer this with the disabling of the use? (I.e. to avoid someone later one trying to renable the use by forgetting to revert this).
There was a problem hiding this comment.
We might be able to write some info in the environment variables, like so:
<download cached artifacts>
echo ROOT_CI_UPLOAD_ARTIFACTS=1 >> $GITHUB_ENV
This environment variable could be used to trigger the upload step. What do you think @pcanal ?
3 participants
For Mac15 and Mac26, the source and build caches aren't used since 4c3335e, so there is no urgent need to generate them at all. Since the Mac VMs sometimes hang for several hours at the upload step, it seems less fragile to not upload or download anything.